STINNER Victor added the comment:

-    if (PyObject_GetBuffer(input, &vbuf, PyBUF_SIMPLE) < 0)
-        return NULL;

Oh by the way, I forgot to mention a subtle change. 
PyObject_GetBuffer(PyBUF_SIMPLE) is less strict that PyArg_Parse("y#") / 
"buffer" converter of Argument Clinic: getargs.c also checks that the buffer is 
contiguous, extract of getbuffer():

    if (!PyBuffer_IsContiguous(view, 'C')) {
        PyBuffer_Release(view);
        *errmsg = "contiguous buffer";
        return -1;
    }

I don't know well the buffer protocol. I don't know any object which provide a 
non-contiguous buffer. At least, I can say that the last time I looked at this 
dark part of Python, the documentation was between tiny and non-existent :-/ 
The buffer protocol is complex but not well documented :-(

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29300>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to