STINNER Victor added the comment: Serhiy Storchaka: "We already made such changes in the past. The difference is subtle and I have doubts that choosing any of ways was deliberate."
Right. IMHO it's safe to make sure that the buffer is contiguous. I'm quite sure that the code doesn't support non-contiguous buffers. Serhiy Storchaka: "Please backport test changes and other changes discussed before to other branches." Done. Sorry, I forgot this part. Serhiy Storchaka: "unpack_buffer.patch LGTM." Thanks for the review, it's now merged. It was a regression in unpack() docstring, Python 3.5 docstring contains "unpack(fmt, buffer)". ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue29300> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
