Aviv Palivoda added the comment: I actually looked at the patch and have a few comments: 1. You need to put Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS before the sqlite3 calls (especially the sleep). 2. I think that the `pysqlite_connection_backup` function will look a lot better if you will have a cleanup/error label.
I am not a core developer but I think you should open the PR as it will be easier for the CR. ---------- nosy: +palaviv _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27645> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
