New submission from Wolfgang Maier:
The current implementation of _iter_file_finder_modules parses folders with a
valid Python module extension as modules (e.g. it would report a *folder* xy.py
as a module xy).
As a result, e.g., pydoc.apropos('') fails if such a folder is found anywhere
on sys.path.
I'm attaching a patch that fixes this and also brings a few minor improvements
(like using a set instead of a dict with 1 values and reusing the function in
ImpImporter).
However, I have a question about it (which is also the reason why I didn't turn
this into a PR right away): in addition to checking that an item detected as a
module is not a directory, I think it would be good to also check that an
__init__ module inside a possible package really is a file. If I uncomment the
respective check in the patch though, I'm getting a test_pydoc failure because
the test creates a package directory with no access to contained file
attributes. So even though there is an __init__.py file in the package dir the
isfile() check fails. I think that should, in fact, happen and the pydoc test
is wrong, but apparently whoever wrote the test had a different opinion.
Any thoughts?
----------
components: Library (Lib)
files: pkgutil.patch
keywords: patch
messages: 289285
nosy: ncoghlan, wolma
priority: normal
severity: normal
status: open
title: pkgutil._iter_file_finder_modules should not be fooled by *.py folders
type: behavior
versions: Python 3.7
Added file: http://bugs.python.org/file46714/pkgutil.patch
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue29769>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
