Cheryl Sabella added the comment: Thank you for that information, Mariatta. I had to read your description twice to find the 9dc2b38 commit hash. Once someone learns this, then they will remember it, but you may want to highlight it on the cherry-pick readme. That was very well written and easy to follow, but I don't remember it specifying the commit hash to use.
Cherry-pick is an awesome tool. Can't wait to use it again! :-) On Mon, May 1, 2017 at 1:25 PM, Mariatta Wijaya <rep...@bugs.python.org> wrote: > > Mariatta Wijaya added the comment: > > One PR per branch is correct. > > For future reference, preferably the commit hash to be cherry-picked is > the one that is merged into CPython's master branch. It can be found at the > original PR where it says <coredeveloper> merged commit <hash> into > python:master. For PR 1353, it is 9dc2b38. > > For this issue, it doesn't make much difference since the PR contains only > one commit. For PRs that contain multiple commits, it makes more sense to > cherry-pick the squashed commit to master :) > > Thanks :) > > ---------- > nosy: +Mariatta > > _______________________________________ > Python tracker <rep...@bugs.python.org> > <http://bugs.python.org/issue30208> > _______________________________________ > ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30208> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
