STINNER Victor added the comment: I reverted the commit which fixes test_datetime to also test Lib/datetime.py, to repair buildbots. But since I reverted the change, nothing was done so datetime.py is still not tested :-(
> The tests enabled by "-utzdata" check UTC to local and back conversions at > several points around *every* time transition in *every* timezone. On systems > with a complete installation of IANA tzdata, this is a lot of test points. > > These tests were supposed to be exhaustive and I did not expect them to be > run by default. that's why I introduced the -utzdata flag in the first place. Alexander: yeah, having an opt-in option to test all timezones makes sense. It's likely to trigger bugs in some corner cases. But the question is really having our CI. Alexander, Serhiy: would you be ok to disable tzdata resource on all our CI (Travis CI, AppVeyor, all buildbots)? *Maybe* we might enable tzdata on selected (fast) buildbots where test_datetime takes less than 20 minutes. But I would prefer to keep the option as an *opt-in*, rather than always running all tests on all CI. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue30822> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
