STINNER Victor <victor.stin...@gmail.com> added the comment: > The check "if isinstance(value, str)" is incorrect, because type of value can > be unicode, while it should be splitted as well.
Your pull request is for Python 3, but the type of paths is expected to be str on Python 3, no? For Python 2, you can use isinstance(value, basestring). ---------- nosy: +haypo versions: +Python 3.7 -Python 3.4, Python 3.5 _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue31955> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com