STINNER Victor <[email protected]> added the comment:
It's easy to reproduce the issue on Linux:
diff --git a/Lib/test/test_asyncio/test_events.py
b/Lib/test/test_asyncio/test_events.py
index 11cd950df1..df4c2b9849 100644
--- a/Lib/test/test_asyncio/test_events.py
+++ b/Lib/test/test_asyncio/test_events.py
@@ -359,7 +359,7 @@ class EventLoopTestsMixin:
called = True
def run():
- time.sleep(0.05)
+ time.sleep(1.0)
f2 = self.loop.run_in_executor(None, run)
f2.cancel()
The problem is that BaseEventLoop.close() shutdowns its default executor
without waiting:
def close(self):
...
executor = self._default_executor
if executor is not None:
self._default_executor = None
executor.shutdown(wait=True)
I fixed a similar issue in socketserver:
* bpo-31233: for socketserver.ThreadingMixIn
* bpo-31151: for socketserver.ForkingMixIn
* bpo-33540: add block_on_close attr to socketserver
I suggest to wait by default, but maybe also add a block_on_close attribute to
BaseEventLoop (default: False) just for backward compatibility.
What do you think Yury, Andrew, and Guido?
----------
nosy: +gvanrossum
_______________________________________
Python tracker <[email protected]>
<https://bugs.python.org/issue34037>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
