STINNER Victor <[EMAIL PROTECTED]> added the comment: I like the method, but I have some comments about the new method: - datetime_totimestamp() is not well indented - "PyObject *time" should be defined at the before the first instruction - why not using "if (time == NULL) return NULL;" directly instead of using a block in case of time is not NULL? - there are reference leaks: timetuple, timestamp and PyFloat_FromDouble()
I wrote a similar patch before reading add-datetime-totimestamp-method.diff which does exactly the same... I attach my patch but both should be merged. Added file: http://bugs.python.org/file12013/datetime_totimestamp.patch _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2736> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
