Jeroen Demeyer <j.deme...@ugent.be> added the comment:

> I'm also mildly concerned by how duplicative the code becomes post-patch.

I know, that's why I added that comment on GitHub.

> perhaps just implement _PyTime_ObjectToTime_t as a wrapper for 
> _PyTime_ObjectToDenominator

Sure, but will that increase the chances of PR 11636 being accepted? Unless a 
core developer who is willing to merge that PR asks me that, I'd rather not add 
extra complications to that PR. (to be clear: I mean no offense, it's just that 
getting a CPython PR accepted is hard)

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue35707>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to