Ammar Askar <am...@ammaraskar.com> added the comment:
I can't speak to the complexity of the choices function but if you're proposing an alternative implementation for choices, it would be wise to show the benefits empirically. That is, benchmarks and an explanation of why your implementation would be better than just an example of your code among an example. Additionally, you need to expand your implementation to match all the functionality of the current function and make a pull request to the main Python repository. Adding Raymond to nosy, the original author of random.choices ---------- nosy: +ammar2, rhettinger _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue35980> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
