Cheryl Sabella <cheryl.sabe...@gmail.com> added the comment:

@carlbordum, thank you for the PR, but the original PR already addresses the 
issues.  In a code review message on that PR 
(https://github.com/python/cpython/pull/1034#pullrequestreview-32006381), 
@rhettinger commented on the removal of the print statement in the method call, 
which was addressed by the creator of that PR.  PR1034 was just waiting for 
final review and approval.

The difference between this and the print in the classmethod example is that 
having to two prints in this example resulted in output of:
  >>> E.f(3)
  3
  >>> print(E.f(3))
  3
  None

whereas the classmethod example doesn't have the issue of printing `None`.

I don't think the second PR is necessary.

----------
nosy: +cheryl.sabella
versions:  -Python 3.4, Python 3.5, Python 3.6

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue23984>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to