Steve Dower <steve.do...@python.org> added the comment:
So an important aspect of the "fix" is that this message only appears after the fix has been applied. Anyone running into this locally has already updated those files, and just needs to "git add -u" to include them in their next commit. (Unfortunately, MSBuild has no reasonable way to retrigger a build it has already completed, since that introduces cycles into its dependency resolution.) The problem here is that when a non-Windows developer sees this error in CI, it's not clear what *they* should do about it. The current text is: "@(_Updated->'%(Filename)%(Extension)',', ') updated. You will need to rebuild pythoncore to see the changes." The PR adds: "You may also need to run 'make regen-all'." I'd propose adding "%0D%0A%0D%0AIf you are developing on another platform, try make regen-all and commit the updated files" (The %0D%0A's at the start add newlines to the output for readability.) As an aside, I thought we had a merge hook to check this on Travis? Why didn't that trigger? There's no reason why any of our CI platforms should let you build with out-of-date frozens, so it's a bit of a shame to blame the Windows build for doing its job properly :) ---------- versions: +Python 3.7, Python 3.8, Python 3.9 _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue36448> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
