Karthikeyan Singaravelan <tir.kar...@gmail.com> added the comment:
I think this is an easy issue. The relevant code is at https://github.com/python/cpython/blob/cec01849f142ea96731b4725975b89d3af757656/Lib/collections/__init__.py#L1210 where the encoded result has to be fixed. Trey, if you haven't started working on it I think it's a good first issue for sprints. A simple unittest patch that fails on master. This can have additional tests with both encoding and errors present and both of them absent hitting all three code paths in the function. diff --git a/Lib/test/test_userstring.py b/Lib/test/test_userstring.py index 71528223d3..81a4908dbd 100644 --- a/Lib/test/test_userstring.py +++ b/Lib/test/test_userstring.py @@ -39,6 +39,11 @@ class UserStringTest( # we don't fix the arguments, because UserString can't cope with it getattr(object, methodname)(*args) + def test_encode(self): + data = UserString("hello") + self.assertEqual(data.encode(encoding='utf-8'), b'hello') if __name__ == "__main__": unittest.main() ---------- nosy: +Mariatta, cheryl.sabella, xtreak _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue36582> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
