Gregory P. Smith <[EMAIL PROTECTED]> added the comment: patch looks good to me.
nitpick comments: use += instead of = and + in: newsize = newsize + newsize and newsize = newsize + BIGCHUNK. As for the XXX about overflow, so long as BUFSIZ is not defined to be an insanely large number (it should never be) this will be fine. add a preprocessor test for that in. #if (BUFSIZ >= 2**30) #error "unreasonable BUFSIZ defined" #endif ---------- nosy: +gregory.p.smith _______________________________________ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue4533> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
