STINNER Victor <vstin...@redhat.com> added the comment:

Łukasz Langa reverted my change (PR 13786). I pushed my change without any 
review to try to fix https://bugs.python.org/issue37137 which blocked the 
Python 3.8 beta1. Sadly, my change didn't fix this issue. The root cause was 
differently (and it's now fixed).

Andrew Svetlov asked to make some changes on my API. Yury Selivanov added "I 
don't like this last minute api decision. Please don't merge this.". See PR 
13786 for the discussion. In short, my change was reverted because of the API.

But I still consider that calling executor.shutdown(wait=False) in loop.close() 
in wrong: we must wait until it finishes. Otherwise, the code "leaks" threads 
which continue to run and so can cause troubles. I would prefer to wait by 
default.

Andrew, Yury: Would you be interested to rewrite my change in the "asyncio way"?

IMHO this change can wait Python 3.9, it's not a critical bug.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue34037>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to