Serhiy Storchaka <[email protected]> added the comment:
Why this code uses int() at all? My guess is that it was added for earlier
detection of user errors, otherwise the user could get a TypeError or
AttributeError with unrelated message, or even a wrong result. int() is used
just for type checking. But it is not good tool for this. int() does several
different actions:
1. Parses string representation of integer.
2. Converts a real number to an integer with some truncation.
3. Losslessly converts an int-like number into an instance of int.
The first two options are not applicable here, so we need an additional check
if istart != start:
raise ValueError("non-integer arg 1 for randrange()")
And this is not perfect: for randrange('5') we get a ValueError instead of
expected TypeError.
operator.index() is better tool for this.
----------
_______________________________________
Python tracker <[email protected]>
<https://bugs.python.org/issue37319>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
