Serhiy Storchaka <storchaka+cpyt...@gmail.com> added the comment:
Thank you for your patch hai shi. But note that assertion_error is a static variable. It is initialized only once. Your change makes it holding a borrowed reference after first call of compiler_assert(). This does not look reliable. In any case assertion_error will gone after resolving issue34880, so I am closing this issue in favor of that. If not issue34880, it would be better to use a private API for _Py_IDENTIFIER here. ---------- nosy: +serhiy.storchaka resolution: -> rejected stage: -> resolved status: open -> closed _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue37887> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com