STINNER Victor <vstin...@python.org> added the comment:
> As mentioned in the code review for Victor's fix, it feels like the big > conditional on the use of self._posix_spawn in Popen._execute_child should > perhaps be pulled into _posix_spawn, or at least refactored so it's closer to > _posix_spawn, with some explanation about what is or isn't supported by > _posix_spawn and why. Maybe, yes. But having tests in the caller avoids to pass the very long list of arguments. Especially, it avoids to pass arguments which are not supposed by posix_spawn() :-) _execute_child() has 21 arguments... is that really reasonable? Maybe we should put these stuff into a temporary object? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue36046> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
