Marc-Andre Lemburg <m...@egenix.com> added the comment: On 2009-01-18 22:59, Mark Dickinson wrote: > Mark Dickinson <dicki...@gmail.com> added the comment: > > Looks good to me. > > I'm not in a position to test with 16-bit wchar_t, but I can't see why > anything would go wrong. I think we can take our chances: check this in > and watch the buildbots for signs of trouble. > > Some minor whitespace issues in the unicodeobject.c part of the patch > (mixing of tabs and spaces, one brace indented oddly), but those can > easily be taken care of before committing; not worth regenerating the > patch for. > > Marc-André, is it okay with you to check this in?
I'd structure the patch differently, ie. put the whole support code into a single #ifndef Py_UNICODE_WIDE section as part of the #ifdef HAVE_USABLE_WCHAR_T pre-processor statement. Also note that on platforms with 16-bit wchar_t, the comparison (0xffff < *w) will always be false, so an additional check for (Py_UNICODE_SIZE > 2) is needed. BTW: Please always use upper-case hex literals, or at leat don't mix the case within the same function. Thanks, -- Marc-Andre Lemburg eGenix.com ________________________________________________________________________ ::: Try our new mxODBC.Connect Python Database Interface for free ! :::: eGenix.com Software, Skills and Services GmbH Pastor-Loeh-Str.48 D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg Registered at Amtsgericht Duesseldorf: HRB 46611 http://www.egenix.com/company/contact/ _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4474> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com