STINNER Victor <vstin...@python.org> added the comment:

Python/fileutils.c might be a better home for such helper function.

You might move _Py_BEGIN_SUPPRESS_IPH / _Py_END_SUPPRESS_IPH macros into 
_Py_closerange(), even if currently it makes no diffence. 
(_Py_BEGIN_SUPPRESS_IPH is specific to Windows, os.closerange() uses it, and 
_posixsubprocess doesn't need it since it's not used on Windows.)

See also the idea of reminding if the kernel supports the syscall or not:
https://github.com/python/cpython/pull/22651#pullrequestreview-506215041

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue40422>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to