Serhiy Storchaka <storchaka+cpyt...@gmail.com> added the comment:
PyModule_Add() allows to make such macro much simpler:
#define MOD_ADD(name, expr) \
do { \
if (PyModule_Add(mod, name, expr) < 0) { \
return -1; \
} \
} while (0)
PyModule_AddObjectRef() is just Py_XINCREF() followed by PyModule_Add(). But
since most values added to the module are new references, Py_XINCREF() is
usually not needed. The PyModule_Add* API is a convenient API. It is not
necessary, you can use PyModule_GetDict() + PyDict_SetItemString(), but with
this API it is easier. And PyModule_Add() is a correct PyModule_AddObject()
(which was broken a long time ago and cannot be fixed now) and is more
convenient than PyModule_AddObjectRef().
PyModule_AddIntConstant() and PyModule_AddStringConstant() can be easily
expressed in terms of PyModule_Add():
PyModule_Add(m, name, PyLong_FromLong(value))
PyModule_Add(m, name, PyUnicode_FromString(value))
And it is easy to combine it with other functions: PyLong_FromLongLong(),
PyLong_FromUnsignedLong(), PyLong_FromVoidPtr(), PyFloat_FromDouble(),
PyCapsule_New(), PyType_FromSpec(), etc.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue42327>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
