Austin Lamb <austin.l...@microsoft.com> added the comment:
You're right to think that folding is a problem Steve, but thankfully my PR does not enable COMDAT folding for that very reason :). /OPT:ICF enables identical COMDAT folding, but surprisingly-to-me /OPT:REF seems to still enable a small amount of folding (I confirmed with the linker dev at Microsoft that this is true). Thus, just /OPT:REF alone caused test failures as there are test cases verifying COMDAT folding didn't occur. Thus, in my PR I am using /OPT:REF,NOICF to explicitly disable any ICF'ing at all and I see no folding occurring anywhere, and those COMDAT-folding-sensitive tests pass with that flag. The dumpbin /exports output is identical after this change. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue42825> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
