STINNER Victor <vstin...@python.org> added the comment:

> IMO, we can drop most (all?) of the huge comment before the check in 
> object_set_class().

I don't think so. I don't understand why it's allowed to override the __class__ 
attribute of ModuleType instances whereas it's a static type. IMO the long 
comment remains useful and something should be done later to make the condition 
more generic, rather than checking PyType_IsSubtype(newto, &PyModule_Type) 
specifically.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue43973>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to