New submission from Rory Yorke <[email protected]>:
I'm probably missing something, but "master" seems hard-coded into
patchcheck.py, and I couldn't find any related issues on bpo.
Checked on branch off 42fcad2.
When I ran patchcheck:
rory@rory-latitude:~/src/cpython$ ./python Tools/scripts/patchcheck.py
Getting base branch for PR ... origin/master
Getting the list of files that have been added/changed ... fatal: ambiguous
argument 'origin/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
0 files
<snip>
The obvious offender is line 81 of Tools/scripts/patchcheck.py:
base_branch = "master"
Changing this to "main" results in useful output, but I imagine one
would want to check for both "master" and "main" for a while yet?
----------
components: Demos and Tools
messages: 393244
nosy: roryyorke
priority: normal
severity: normal
status: open
title: patchcheck checks against branch "master" not "main"
_______________________________________
Python tracker <[email protected]>
<https://bugs.python.org/issue44074>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
