Pablo Galindo Salgado <pablog...@gmail.com> added the comment:

Actually, this has even more problems. Because we are using strstr to find the 
start of the expression in the parent string, if the expression is repeated the 
offsets are incorrectly generated:

For example:

print(f"Here is that {xxx} pesky {xxx} again")

This produces:

...
                     FormattedValue(
                        value=Name(
                           id='xxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=22,
                           end_lineno=1,
                           end_col_offset=25),
...
                     FormattedValue(
                        value=Name(
                           id='xxxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=22,
                           end_lineno=1,
                           end_col_offset=25),
...

while

print(f"Here is that {xxx} pesky {xxxx} again")

(different variables) produces:

...
                     FormattedValue(
                        value=Name(
                           id='xxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=22,
                           end_lineno=1,
                           end_col_offset=25),
...
                     FormattedValue(
                        value=Name(
                           id='xxxx',
                           ctx=Load(),
                           lineno=1,
                           col_offset=34,
                           end_lineno=1,
                           end_col_offset=38),
...

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue44885>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to