STINNER Victor <vstin...@python.org> added the comment:

Raymond:
> Perhaps these critical code sections should have been left as macros. It is 
> difficult to assuring system wide inlining across modules.

These functions were not converted recently to static inline function. For 
example, Py_INCREF() was already a static inline function in Python 3.9. I 
don't think that any decision should be taken before performances have been 
analyzed in depth.

I'm not convinced that there is really a performance regression. I'm not sure 
how benchmarks are run on Windows.

neonene:
> I measured overheads of (1)~(4) on my own build whose eval-loop uses macros 
> instead of them.

I don't understand how to read the table.

Usually, I expect a comparison between a reference build and a patch build, but 
here you seem to use 3.10a7 as the reference to compare results. I'm not sure 
that geometric means can be compared this way.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue45116>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to