Marc-Andre Lemburg <m...@egenix.com> added the comment:
On 26.10.2021 19:42, Christian Heimes wrote: > > Brett removed a lot of stuff in 01cf4fb9c1aa567484c2ffb1b11f9b3fe9949b05 to > make the file more readable. I removed unnecessary -D, -I, and -L to make the > file even more readable. You can pass custom flags to ./configure. Could Brett or you please add those notes back ? There's no other place where such details are documented. We've lost important information and I would like to get this back into Setup and ideally add more information to make it easier for users or admins to customize their build. Regarding the -I and -L flags, my question was whether these are now added elsewhere, since the code would not compile without e.g. -I$(srcdir)/Include/internal. I've gone through the Makefile and found that these are already added via PY_CFLAGS_NODIST, so they are indeed not needed in Setup. That's great :-) Please be careful when moving e.g. -I or -L options which point to non-Python directories. If such options get moved into e.g. PY_CFLAGS_NODIST, there's no way to override them via options given in Setup. Having the -D defined in the relevant code is a lot better. Thanks for that :-) > Setup should not be edited by hand. Customizations go to Setup.local. Editing Setup.local instead of Setup is not documented anywhere ?! Both files are read, so I guess it's not all that relevant which of the two are edited. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue45548> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com