Erlend E. Aasland <[email protected]> added the comment:
Quoting msg407949:
> [...] We should do something like
>
> ZLIB_CFLAGS=${ZLIB_CFLAGS:-""}
> ZLIB_LIBS=${ZLIB_LIBS:-"-lz"}
>
> for all env vars.
I think we should use ${VAR-default} instead of ${VAR:-default}; we only want
to override if the variable is _not_ set:
$ TEST=
$ echo ${TEST-default}
$ echo ${TEST:-default}
default
$ unset TEST
$ echo ${TEST-default}
default
$ echo ${TEST:-default}
default
> I prefer the syntax over ${ZLIB_CFLAGS:=""} because it is more obvious what
> is happening.
I agree. I also prefer `TEST=${TEST-""}` to `TEST=${TEST-}` for empty strings.
----------
_______________________________________
Python tracker <[email protected]>
<https://bugs.python.org/issue45847>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
