Jakub Kulik <[email protected]> added the comment:
This also broke our Solaris build with the following error:
======================================================================
FAIL: testGetaddrinfo (test.test_socket.GeneralModuleTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/..../cpython-main/Lib/test/test_socket.py", line 1523, in
testGetaddrinfo
self.assertEqual(repr(type), '<SocketKind.SOCK_STREAM: 1>')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<SocketKind.SOCK_STREAM: 2>' != '<SocketKind.SOCK_STREAM: 1>'
- <SocketKind.SOCK_STREAM: 2>
? ^
+ <SocketKind.SOCK_STREAM: 1>
? ^
(test.test_socket.GeneralModuleTests fails with the same error).
The issue is almost certainly that on Solaris, SOCK_STREAM is defined as 2
rather than 1; the following simple program confirms that:
#include <stdio.h>
#include <sys/socket.h>
void main() {
printf("%d\n", SOCK_STREAM);
}
I'm just not sure whether to fix this with `assertRegex` or a special branch
for Solaris (though I am not sure whether everybody else uses 1 or it's more
varied).
----------
nosy: +kulikjak
_______________________________________
Python tracker <[email protected]>
<https://bugs.python.org/issue40066>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
