Eryk Sun <[email protected]> added the comment:
> the fix should be as simple as coercing the timeout values to >= 0.
Popen._remaining_time() should return max(endtime - _time(), 0).
Popen._wait() should raise OverflowError if the timeout is too large for the
implementation. In Windows, the upper limit in milliseconds is
`_winapi.INFINITE - 1` (about 49.7 days). It's important to only allow the
timeout in milliseconds to be _winapi.INFINITE when `timeout is None`.
The DWORD converter in _winapi needs to subclass unsigned_long_converter. The
current implementation based on the legacy format unit "k" is too lenient.
Negative values and values that are too large should fail. I updated it to use
the following definition:
class DWORD_converter(unsigned_long_converter):
type = 'DWORD'
This produces the following improved results:
>>> h = _winapi.GetCurrentProcess()
>>> _winapi.WaitForSingleObject(h, _winapi.INFINITE + 1)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
OverflowError: Python int too large to convert to C unsigned long
>>> _winapi.WaitForSingleObject(h, -1)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: value must be positive
----------
_______________________________________
Python tracker <[email protected]>
<https://bugs.python.org/issue46716>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
