Amaury Forgeot d'Arc <amaur...@gmail.com> added the comment:

This (old) patch needs some work:

- unit tests are neeeded.

- it it not enough to return NULL when XML_ParserReset() returns an
error; a python exception must be raised.

- "This function may not be used on a parser created using
XML_ExternalEntityParserCreate": if XML_ParserReset() does not check it
properly, we should ensure that an exception is properly raised.

- "How many of the struct elements do I need to reset?": this should be
worked out. And I'm not convinced that self->intern should be reset.

----------
nosy: +amaury.forgeotdarc

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue1208730>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to