Antoine Pitrou <pit...@free.fr> added the comment: >From a quick look at the patch, if you call login() twice, the socket will be wrapped twice as well? Perhaps auth_tls() should have a protection against this.
In prot_p() and prot_c(), it seems that self._prot_p is updated unconditionally, regardless of the FTP response. In retrbinary(), retrlines(), storbinary() and storlines(), you certainly want some try/finally blocks so that the data connection always gets closed at the end. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue2054> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com