Gregory P. Smith <g...@krypto.org> added the comment: Reviewers: ,
http://codereview.appspot.com/150055/diff/1/4 File Modules/_threadmodule.c (right): http://codereview.appspot.com/150055/diff/1/4#newcode221 Modules/_threadmodule.c:221: return PyBool_FromLong((long) r); This explicit (long) cast is unnecessary. http://codereview.appspot.com/150055/diff/1/4#newcode246 Modules/_threadmodule.c:246: PyThread_release_lock(self->rlock_lock); reset self->rlock_owner to 0 before releasing the lock. Description: code review for http://bugs.python.org/issue3001 Please review this at http://codereview.appspot.com/150055 Affected files: M Lib/test/test_threading.py M Lib/threading.py M Modules/_threadmodule.c ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue3001> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com