Derk Drukker <derk.druk...@gmail.com> added the comment: orsenthil: I reverted the changes that make Windows and Unix use the same code in Patch Set 3, and briefly mentioned the reason for that in the Rietveld app. I should have mentioned it here too.
It was because it actually makes the implementation on Unix worse, since the Windows implementation reads all data in memory. (The subprocess module documentation has this note: "The data read is buffered in memory, so do not use this method if the data size is large or unlimited.") I tried replacing subprocess.PIPE with rfile/wfile, but it turns out that that won't work, because on Windows socket.fileno() cannot be used where file descriptors can be used, as the socket module documentation states. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue1235> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
