Amaury Forgeot d'Arc <amaur...@gmail.com> added the comment:

Here is my review of issue7092_syntax_imports_v3.diff:

- test_itertools.py: please replace
      [tuple([arg[i] if i < len(arg) else None for arg in args])
       for i in range(max(map(len, args)))]
  by something more readable (nested for loops for example)

- test_mailbox.py: why doesn't test_support.import_module('rfc822')
  specify deprecated=True? maybe the module can be imported normally...

- test_pyclbr.py:   replace self.assertTrue(key in obj) with assertIn()
- test_wsgiref.py:  replace self.assertTrue(key in h.environ)

- test_queue.py: test could be identical to the one in py3k.

----------
nosy: +amaury.forgeotdarc

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7092>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to