Antoine Pitrou <pit...@free.fr> added the comment:

I didn't test the patch but some comments:
- PyThreadState_Prealloc and PyThreadState_Init should probably be prefixed 
with an underscore, because there's no use for them outside of the interpreter
- _PyThreadState_New should be static. Besides, static functions usually don't 
get the "Py" in their name and are all lowercased, so something like 
"new_threadstate"
- the last change ("Py_InitializeEx() calls _PyGILState_Init() before 
initsite()") should be part of a separate patch (and issue?)

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7544>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to