Jason R. Coombs <jar...@jaraco.com> added the comment:

Brian, thanks for the review. I really appreciate it. I'll fix all of the 
identified issues.

> Lib/test/test_posixpath.py
> - Lines 365-366 - why check has_symlink() and immediately check it
> again?

In the unpatched code, there were two calls that checked for the existence of 
'symlink' in the os module. I thought it strange too, but left it assuming it 
was there for some reason and not wanting to over extend beyond my primary 
objective. I will rewrite that test to use only one check unless someone posts 
otherwise.

----------
title: Add os.link() and os.symlink() and       os.path.islink() support for 
Windows -> Add os.link() and os.symlink() and os.path.islink()     support for 
Windows

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue1578269>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to