Mark Dickinson <dicki...@gmail.com> added the comment:

The latest patch looks fine.  I've attached a slightly tweaked version:

 - Add conversions for number_class;  without this, number_class is 
inconsistent with the various is_*** methods.  "c.is_normal(3)" should be 
equivalent to "c.number_class(3) in ('+Normal', '-Normal)", for example.

 - Remove conversions for 'canonical' and 'is_canonical';  I agree with Stefan 
that these don't make a lot of sense.  It's mostly academic, since I can't 
imagine either of these methods gets much use.

 - I've reworded the documentation slightly.

 - Remove lots of trailing whitespace (mostly on otherwise empty lines).

If this looks okay to everyone, I'll check it in.

----------
Added file: http://bugs.python.org/file16245/issue7633_jjconti4_metd.patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7633>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to