Steven Bethard <steven.beth...@gmail.com> added the comment:

Thanks for the patch! One concern I have is that adding --help-options by 
default has the potential to break existing code, e.g. if someone using 
optparse or argparse was already defining their own --help-options flag. The 
backward compatible solution is to have --help-options disabled by default, and 
ask people to enable it with add_interface=True.

Comments on the argparse patch: I think it's probably overkill to create 
InterfaceFormatter - just do the appropriate formatting in the 
_InterfaceAction. I also wouldn't add format_interface or print_interface until 
someone requests them. Last nit: don't add the takes_value method, just inline 
your "self.nargs != 0" check in the one place you need it.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue4256>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to