Antoine Pitrou <pit...@free.fr> added the comment: On the principle the patch looks good. In practice, it lacks a call to `PyBuffer_Release(&buffer)` in the various error cases (before returning NULL). It also lacks some tests in Lib/test/test_array.py.
> In 3.x unicode type was renamed to str and str to bytes, so fromunicode > should become fromstring (or maybe fromstr to avoid confusion) and > fromstring should become frombytes. This should be discussed separately, perhaps on python-dev first. ---------- nosy: +haypo, pitrou _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue8990> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
