Dave Malcolm <dmalc...@redhat.com> added the comment:

Thanks.  The patch looks good to me, and appears to also fix issue 8482 and 
issue 9163: compiler optimization across all different compilers and 
configurations can somewhat arbitrarily break the ability for the debugger to 
work, and skipping the test in the face of optimization seems the sanest course 
of action.

Minor nit: given that final_opt is set to "" at the start of the loop, the 
first conditional in:
    if final_opt and final_opt != '-O0':
appears to be redundant.

Setting "Stage" to "commit review" - I'd commit it (modulo the above nit), but 
I don't have rights to do so; looking for a committer to review this.

----------
stage: needs patch -> commit review

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue8605>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to