Alexander Belopolsky <belopol...@users.sourceforge.net> added the comment:

There is nothing we can do about misreporting of UTC offset.  Unlike time 
tuples, datetime objects do not store the DST flag and thus have no means to 
disambiguate between standard and DST during the hour after the clock is set 
back for DST to standard transition.

Nevertheless, dt = datetime.fromtimestamp(t) is a well defined operation, it is 
dt.dst() and dt.utcoffset() which are not so well defined.

According to the comment at the end of Modules/datetimemodule.c, in order for 
the default implementation of tzinfo.fromutc() to operate correctly, the 
concrete implementation of tzinfo.dst(dt) must treat dt that falls into the 
ambiguous hour (where it can be ether DST or standard time) as the standard 
time.  This is precisely what is done in the implementation of USTimeZone 
class.  The Local class, however, relies on mktime to choose between DST and 
standard and apparently, at least on OSX, mktime does not do what Python's 
tzinfo.fromutc() expects.

The attached patch for Doc/includes/tzinfo-examples.py fixes this problem by 
passing is_dst=0 instead of -1 to mktime and also adds __repr__ to 
LocalTimezone class.

With this patch,

>>> x = datetime(2010, 11, 7, 5)
>>> s = (x - datetime(1970, 1, 1))//timedelta(seconds=1)
>>> for i in range(-3600, 5000, 3600):
...     datetime.fromtimestamp(s + i, Local)
... 
datetime.datetime(2010, 11, 7, 0, 0, tzinfo=EST/EDT)
datetime.datetime(2010, 11, 7, 1, 0, tzinfo=EST/EDT)
datetime.datetime(2010, 11, 7, 1, 0, tzinfo=EST/EDT)

which is correct and consistent with Easter timezone:

>>> for i in range(-3600, 5000, 3600):
...     datetime.fromtimestamp(s + i, Eastern)
... 
datetime.datetime(2010, 11, 7, 0, 0, tzinfo=Eastern)
datetime.datetime(2010, 11, 7, 1, 0, tzinfo=Eastern)
datetime.datetime(2010, 11, 7, 1, 0, tzinfo=Eastern)

----------
keywords: +patch
nosy: +mark.dickinson
stage: needs patch -> commit review
type:  -> behavior
Added file: http://bugs.python.org/file17892/issue9063.diff

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9063>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to