Antoine Pitrou <pit...@free.fr> added the comment:

> I wasn't really precise. The test fails on Linux, but for a different reason.
> Linux legitimately sets ENAMETOOLONG and raises OSError. This only becomes
> apparent when using 4098 in the test.
> 
> Solaris, on the other hand, does not even raise, since it keeps setting
> ERANGE and thus does not leave the loop in posix_getcwd(). IOW, only the
> fix in posixmodule.c allows the test to fail properly in the first place.

Ok. Still, silencing all OSErrors in test_posix is much too broad. The
code should check for expected error codes, possibly depending on the
OS.

> If you prefer, of course it's possible to be conservative and make the new
> version of posix_getcwd() Solaris specific.

I think this would be the most reasonable solution for 2.7, indeed.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9185>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to