Eric Smith <[email protected]> added the comment:
The feature request seems reasonable to me, too.
I don't recall if sys.getdefaultencoding() can change while a program is
running. If so, you might want to change:
def read(self, filenames, encoding=sys.getdefaultencoding()):
to:
def read(self, filenames, encoding=None):
if encoding is None:
encoding=sys.getdefaultencoding()
Also, what if the files have different encodings?
The patch seems to include 2 features: the encoding change and a comment
parsing change. You should separate that into two patches.
----------
nosy: +eric.smith
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue9411>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
