Marko Kohtala <marko.koht...@gmail.com> added the comment:

Thank you for the review.

I have very limited time to use on this. So even when I'd like to make 
everything easy for you, have the time you give to python be as productive as 
possible, I can not.

But I'll respond to your comments on the patch.

a) I added the quotes to every identifier based on a comment in sqlite 
documentation "SQLite adds new keywords from time to time when it takes on new 
features. So to prevent your code from being broken by future enhancements, you 
should normally quote any identifier that is an English language word, even if 
you do not have to." While fixing one place, I fixed it to follow this 
recommendation in other places as well.

b) I added quotes using backslashes because it was consistent. The table name 
was already quoted like that. I agree it could be clearer.

c) I know. I only tried to make minimal changes targeted only to the issues at 
hand. I did not want to hide the fixes in middlde of changes to style.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9750>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to