Antoine Pitrou <pit...@free.fr> added the comment:

> I've wrapped the whole of get_frame_marker_info with a
> PyErr_Fetch/PyErr_Restore pair: the PyUnicode_AsUTF8String calls could
> fail with a MemoryError, and we don't want to confuse the regular
> exception handling within ceval.

If PyUnicode_AsUTF8String() is meant to encode a filename, you should
use PyUnicode_EncodeFSDefault() instead.

> The non-ASCII script name (Lib/test/systemtap_sample_☠.py) may be
> controversial: do we have anything like that in the source tree yet?
> Is there any risk of messing up the build across platforms, or of
> impacting the Hg migration?

It would be better to generate the sample dynamically, so that users
with an incompatible locale or filesystem aren't prevented from checking
out the source.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue4111>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to