Andrew Vant <ajv...@gmail.com> added the comment: On 6 Nov 2010 at 11:48, Antoine Pitrou wrote:
> I would rename setreadermode to _setreadermode (there's no reason to > make it public IMO). Also, I would not explicitly check "STARTTLS" in > the capabilities. It the server doesn't support it, it will issue an > error anyway. Some servers might support it without advertising it, > who knows? > > I can take care of all that when committing, you don't need to submit > a new patch (you can of course, if you want). I'd appreciate it if you took care of it, if you feel the patch is otherwise commit-worthy. It takes a pretty excessive amount of time to convince myself that it's really doing what I want it to (and only what I want it to). I forgot to include a note for Misc/NEWS in the new patch version, by the way. > > (in fact I think usenetrc should be false by default for this > > reason, but I figure that would break backwards compatibility for > > programs that rely on it being true by default, and I'm not sure > > what the rules are regarding this) > > In 3.2, the reworked nntplib already breaks compatibility. It is > reasonable to switch the default for usenetrc to False; but I prefer > to do it in a separate commit for clarity. Okay. For the time being I left a note in the documentation pointing out that it had to be set False for starttls to be useful. -- Andrew ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue1926> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
