R. David Murray <rdmur...@bitdance.com> added the comment: Here is an updated patch that addresses the concerns I noted. I modified the tests: given that I've changed the code to raise binascii.Error as discussed, we don't really care from an API point of view what the error text is, just that the error is raised in the cases given. Nor do we care (again, from an API point of view) if the first error detected is the invalid character or the invalid padding.
I made the new test test the validate=False case, so all of the invalid character tests are now correctly padded if you ignore the invalid characters. ---------- Added file: http://bugs.python.org/file19548/binascii-validate.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue1466065> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com