Éric Araujo <mer...@netwok.org> added the comment: Raymond: I made a single diff for easier review. I’m not 100% sure I should change 'r' to 'rb' in logging: It’s unrelated to with, and the rest of the file has not been checked for similar errors. I prefer to do commits that don’t mix things.
Eli: > which whitespace change do you refer to. I changed to 4-spaces > indentation in the code sample to conform to PEP-8. Shouldn't I have? PEP 8 only applies to Python code. http://docs.python.org/dev/documenting/style applies to the docs. ---------- Added file: http://bugs.python.org/file19765/with-in-docs-1.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue10461> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com